Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Advanced logger for Non DXE phases #801

Merged
merged 12 commits into from
Dec 20, 2023

Conversation

kuqin12
Copy link
Contributor

@kuqin12 kuqin12 commented Dec 15, 2023

Description

This change introduces non DXE advanced logger, which should enable us to verify the advanced logger related changes better. Resolves #522.

  • Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • Impacts security?
    • Security - Does the change have a direct security impact on an application,
      flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter
      validation improvement, ...
  • Breaking change?
    • Breaking change - Will anyone consuming this change experience a break
      in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call
      a function in a new library class in a pre-existing module, ...
  • Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • Includes documentation?
    • Documentation - Does the change contain explicit documentation additions
      outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation
      on an a separate Web page, ...

How This Was Tested

This change was tested on both QEMU Q35 and SBSA packages and verified bootable to UEFI shell.

Integration Instructions

N/A

Platforms/QemuQ35Pkg/QemuQ35Pkg.dsc Outdated Show resolved Hide resolved
Platforms/QemuQ35Pkg/QemuQ35Pkg.dsc Outdated Show resolved Hide resolved
Platforms/QemuQ35Pkg/QemuQ35Pkg.fdf Outdated Show resolved Hide resolved
Signed-off-by: kuqin12 <42554914+kuqin12@users.noreply.github.com>
Signed-off-by: kuqin12 <42554914+kuqin12@users.noreply.github.com>
@makubacki
Copy link
Member

@kuqin12, what is the current state of this PR?

@kuqin12
Copy link
Contributor Author

kuqin12 commented Dec 19, 2023

@kuqin12, what is the current state of this PR?

Should be ready to go. Tested on both Q35 and SBSA.

@makubacki
Copy link
Member

Regarding #522. It states:

Advanced Logger is enabled in DXE on Q35 and SBSA, and it should be enabled in all phases.

Add PEIM, PEI_CORE, MM_CORE, and MM_STANDALONE instances of AdvancedLoggerLib and the Advanced Logger DebugLib.

For future reference, I think the issue should mention that for QemuSbsaPkg, MM_CORE_STANDALONE and MM_STANDALONE are not covered due to support being limited to TFA.

@kuqin12
Copy link
Contributor Author

kuqin12 commented Dec 20, 2023

Regarding #522. It states:

Advanced Logger is enabled in DXE on Q35 and SBSA, and it should be enabled in all phases.

Add PEIM, PEI_CORE, MM_CORE, and MM_STANDALONE instances of AdvancedLoggerLib and the Advanced Logger DebugLib.

For future reference, I think the issue should mention that for QemuSbsaPkg, MM_CORE_STANDALONE and MM_STANDALONE are not covered due to support being limited to TFA.

Ah, yes. I was wondering whether I should actually create a new one for that. But that will be a deeper conversation of how we want to pursue TFA modifications. I will at least add a comment there for better reference.

@kuqin12 kuqin12 merged commit c2982a8 into microsoft:main Dec 20, 2023
30 checks passed
@kuqin12 kuqin12 deleted the adv_logger_non_dxe branch December 20, 2023 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Enable Advanced Logger in PEI and MM on Q35 and SBSA
3 participants