Addeding dTPM support for MM Core module type #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Javagedes
approved these changes
Apr 10, 2024
apop5
approved these changes
Apr 10, 2024
ProjectMuBot
referenced
this pull request
in microsoft/mu_tiano_platforms
May 18, 2024
Introduces 17 new commits in [Common/MU_TIANO](https://github.com/microsoft/mu_tiano_plus.git). <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/microsoft/mu_tiano_plus/commit/8eb45196c6ea12c6b3ed2f1a02442c5e0d1775e4">8eb451</a> pip: bump edk2-pytool-library from 0.21.4 to 0.21.5 (<a href="https://github.com/microsoft/mu_tiano_plus/pull/258">#258</a>)</li> <li><a href="https://github.com/microsoft/mu_tiano_plus/commit/7f54cf0c9aa8c652a20b14057bc0e7351fe61d42">7f54cf</a> Addeding dTPM support for MM Core module type (<a href="https://github.com/microsoft/mu_tiano_plus/pull/259">#259</a>)</li> <li><a href="https://github.com/microsoft/mu_tiano_plus/commit/cc52ddf3bfbaccb799eb0fe5a6fb32c93f7c324c">cc52dd</a> Repo File Sync: Update to Mu DevOps 9.1.9 (<a href="https://github.com/microsoft/mu_tiano_plus/pull/260">#260</a>)</li> <li><a href="https://github.com/microsoft/mu_tiano_plus/commit/e564a3c4960601dfef947dcda5ae6d2949cc9b70">e564a3</a> Repo File Sync: Update to Ubuntu Container 0e124c1 (<a href="https://github.com/microsoft/mu_tiano_plus/pull/261">#261</a>)</li> <li><a href="https://github.com/microsoft/mu_tiano_plus/commit/5f5bfc26ed2ce3636cb2cab8fa3b6dec7cde34a7">5f5bfc</a> GitHub Action: Bump robinraju/release-downloader from 1.9 to 1.10 (<a href="https://github.com/microsoft/mu_tiano_plus/pull/262">#262</a>)</li> <li><a href="https://github.com/microsoft/mu_tiano_plus/commit/841f075618afb7d8349e88e74e401e013169e06a">841f07</a> Repo File Sync: synced file(s) with microsoft/mu_devops (<a href="https://github.com/microsoft/mu_tiano_plus/pull/263">#263</a>)</li> <li><a href="https://github.com/microsoft/mu_tiano_plus/commit/496e11085fe3a560bb8d7808e103e31b95d9bc07">496e11</a> pip: bump regex from 2023.12.25 to 2024.4.16 (<a href="https://github.com/microsoft/mu_tiano_plus/pull/264">#264</a>)</li> <li><a href="https://github.com/microsoft/mu_tiano_plus/commit/5f79aa6b9230f5abdd8f9249a5ed16668c31b3ed">5f79aa</a> GitHub Action: Bump robinraju/release-downloader from 1.9 to 1.10 (<a href="https://github.com/microsoft/mu_tiano_plus/pull/265">#265</a>)</li> <li><a href="https://github.com/microsoft/mu_tiano_plus/commit/b8e2eb6a95c464a99976f13487753849c1f6e4b9">b8e2eb</a> pip: bump regex from 2024.4.16 to 2024.4.28 (<a href="https://github.com/microsoft/mu_tiano_plus/pull/267">#267</a>)</li> <li><a href="https://github.com/microsoft/mu_tiano_plus/commit/84a9ca1c96152c7d6baa629dc0b0356d40d67bf6">84a9ca</a> pip: bump edk2-pytool-extensions from 0.27.3 to 0.27.4 (<a href="https://github.com/microsoft/mu_tiano_plus/pull/266">#266</a>)</li> <li><a href="https://github.com/microsoft/mu_tiano_plus/commit/0df708adaf62868328798a65a06ea6a77de92516">0df708</a> Add libspdm submodule</li> <li><a href="https://github.com/microsoft/mu_tiano_plus/commit/29ceca8420adfb4aa559c52d096409f0b7bbbcd0">29ceca</a> [CHERRY-PICK] SecurityPkg: Add TCG PFP 1.06 support.</li> <li><a href="https://github.com/microsoft/mu_tiano_plus/commit/22a8ce506270b6fe5a31def88d47d17759b6b654">22a8ce</a> [CHERRY-PICK] SecurityPkg: add DeviceSecurity support</li> <li><a href="https://github.com/microsoft/mu_tiano_plus/commit/0f203a93082bbe35cd52c50eb0a91fe6be8fc9bb">0f203a</a> SecurityPkg: CI changes for Device Security</li> <li><a href="https://github.com/microsoft/mu_tiano_plus/commit/577b111f92619d4a40c3065b0169b8506fb84637">577b11</a> Repo File Sync: .gitattributes: Prevent line ending conversion (<a href="https://github.com/microsoft/mu_tiano_plus/pull/269">#269</a>)</li> <li><a href="https://github.com/microsoft/mu_tiano_plus/commit/eabab87ce3928cbd3d172ccdc6e8ee6ceee5939b">eabab8</a> pip: bump regex from 2024.4.28 to 2024.5.10 (<a href="https://github.com/microsoft/mu_tiano_plus/pull/270">#270</a>)</li> <li><a href="https://github.com/microsoft/mu_tiano_plus/commit/966c4ee1269cfc7e743659b0e0edd6c03068a5fb">966c4e</a> pip: bump pygount from 1.6.1 to 1.8.0 (<a href="https://github.com/microsoft/mu_tiano_plus/pull/271">#271</a>)</li> </ul> </details> Signed-off-by: Project Mu Bot <mubot@microsoft.com>
cfernald
pushed a commit
to cfernald/mu_tiano_plus
that referenced
this pull request
Jul 20, 2024
Please ensure you have read the [contribution docs](https://github.com/microsoft/mu/blob/master/CONTRIBUTING.md) prior to submitting the pull request. In particular, [pull request guidelines](https://github.com/microsoft/mu/blob/master/CONTRIBUTING.md#pull-request-best-practices). The current dTPM library instance only supports MM_STANDALONE, which makes the MM core module unable to use this instance. This change expands the support for this library to cover MM_CORE_STANDALONE as well. For each item, place an "x" in between `[` and `]` if true. Example: `[x]`. _(you can also check items in the GitHub UI)_ - [x] Impacts functionality? - **Functionality** - Does the change ultimately impact how firmware functions? - Examples: Add a new library, publish a new PPI, update an algorithm, ... - [ ] Impacts security? - **Security** - Does the change have a direct security impact on an application, flow, or firmware? - Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ... - [ ] Breaking change? - **Breaking change** - Will anyone consuming this change experience a break in build or boot behavior? - Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ... - [ ] Includes tests? - **Tests** - Does the change include any explicit test code? - Examples: Unit tests, integration tests, robot tests, ... - [ ] Includes documentation? - **Documentation** - Does the change contain explicit documentation additions outside direct code modifications (and comments)? - Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ... This was tested on QEMU Q35 and verified bootable to UEFI shell. N/A cherry-pick from 7f54cf0
cfernald
pushed a commit
to cfernald/mu_tiano_plus
that referenced
this pull request
Jul 22, 2024
Please ensure you have read the [contribution docs](https://github.com/microsoft/mu/blob/master/CONTRIBUTING.md) prior to submitting the pull request. In particular, [pull request guidelines](https://github.com/microsoft/mu/blob/master/CONTRIBUTING.md#pull-request-best-practices). The current dTPM library instance only supports MM_STANDALONE, which makes the MM core module unable to use this instance. This change expands the support for this library to cover MM_CORE_STANDALONE as well. For each item, place an "x" in between `[` and `]` if true. Example: `[x]`. _(you can also check items in the GitHub UI)_ - [x] Impacts functionality? - **Functionality** - Does the change ultimately impact how firmware functions? - Examples: Add a new library, publish a new PPI, update an algorithm, ... - [ ] Impacts security? - **Security** - Does the change have a direct security impact on an application, flow, or firmware? - Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ... - [ ] Breaking change? - **Breaking change** - Will anyone consuming this change experience a break in build or boot behavior? - Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ... - [ ] Includes tests? - **Tests** - Does the change include any explicit test code? - Examples: Unit tests, integration tests, robot tests, ... - [ ] Includes documentation? - **Documentation** - Does the change contain explicit documentation additions outside direct code modifications (and comments)? - Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ... This was tested on QEMU Q35 and verified bootable to UEFI shell. N/A cherry-pick from 7f54cf0
cfernald
pushed a commit
to cfernald/mu_tiano_plus
that referenced
this pull request
Jul 22, 2024
Please ensure you have read the [contribution docs](https://github.com/microsoft/mu/blob/master/CONTRIBUTING.md) prior to submitting the pull request. In particular, [pull request guidelines](https://github.com/microsoft/mu/blob/master/CONTRIBUTING.md#pull-request-best-practices). The current dTPM library instance only supports MM_STANDALONE, which makes the MM core module unable to use this instance. This change expands the support for this library to cover MM_CORE_STANDALONE as well. For each item, place an "x" in between `[` and `]` if true. Example: `[x]`. _(you can also check items in the GitHub UI)_ - [x] Impacts functionality? - **Functionality** - Does the change ultimately impact how firmware functions? - Examples: Add a new library, publish a new PPI, update an algorithm, ... - [ ] Impacts security? - **Security** - Does the change have a direct security impact on an application, flow, or firmware? - Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ... - [ ] Breaking change? - **Breaking change** - Will anyone consuming this change experience a break in build or boot behavior? - Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ... - [ ] Includes tests? - **Tests** - Does the change include any explicit test code? - Examples: Unit tests, integration tests, robot tests, ... - [ ] Includes documentation? - **Documentation** - Does the change contain explicit documentation additions outside direct code modifications (and comments)? - Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ... This was tested on QEMU Q35 and verified bootable to UEFI shell. N/A cherry-pick from 7f54cf0
cfernald
pushed a commit
to cfernald/mu_tiano_plus
that referenced
this pull request
Jul 22, 2024
Please ensure you have read the [contribution docs](https://github.com/microsoft/mu/blob/master/CONTRIBUTING.md) prior to submitting the pull request. In particular, [pull request guidelines](https://github.com/microsoft/mu/blob/master/CONTRIBUTING.md#pull-request-best-practices). The current dTPM library instance only supports MM_STANDALONE, which makes the MM core module unable to use this instance. This change expands the support for this library to cover MM_CORE_STANDALONE as well. For each item, place an "x" in between `[` and `]` if true. Example: `[x]`. _(you can also check items in the GitHub UI)_ - [x] Impacts functionality? - **Functionality** - Does the change ultimately impact how firmware functions? - Examples: Add a new library, publish a new PPI, update an algorithm, ... - [ ] Impacts security? - **Security** - Does the change have a direct security impact on an application, flow, or firmware? - Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ... - [ ] Breaking change? - **Breaking change** - Will anyone consuming this change experience a break in build or boot behavior? - Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ... - [ ] Includes tests? - **Tests** - Does the change include any explicit test code? - Examples: Unit tests, integration tests, robot tests, ... - [ ] Includes documentation? - **Documentation** - Does the change contain explicit documentation additions outside direct code modifications (and comments)? - Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ... This was tested on QEMU Q35 and verified bootable to UEFI shell. N/A cherry-pick from 7f54cf0
cfernald
pushed a commit
to cfernald/mu_tiano_plus
that referenced
this pull request
Jul 22, 2024
Please ensure you have read the [contribution docs](https://github.com/microsoft/mu/blob/master/CONTRIBUTING.md) prior to submitting the pull request. In particular, [pull request guidelines](https://github.com/microsoft/mu/blob/master/CONTRIBUTING.md#pull-request-best-practices). The current dTPM library instance only supports MM_STANDALONE, which makes the MM core module unable to use this instance. This change expands the support for this library to cover MM_CORE_STANDALONE as well. For each item, place an "x" in between `[` and `]` if true. Example: `[x]`. _(you can also check items in the GitHub UI)_ - [x] Impacts functionality? - **Functionality** - Does the change ultimately impact how firmware functions? - Examples: Add a new library, publish a new PPI, update an algorithm, ... - [ ] Impacts security? - **Security** - Does the change have a direct security impact on an application, flow, or firmware? - Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ... - [ ] Breaking change? - **Breaking change** - Will anyone consuming this change experience a break in build or boot behavior? - Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ... - [ ] Includes tests? - **Tests** - Does the change include any explicit test code? - Examples: Unit tests, integration tests, robot tests, ... - [ ] Includes documentation? - **Documentation** - Does the change contain explicit documentation additions outside direct code modifications (and comments)? - Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ... This was tested on QEMU Q35 and verified bootable to UEFI shell. N/A cherry-pick from 7f54cf0
cfernald
pushed a commit
to cfernald/mu_tiano_plus
that referenced
this pull request
Jul 23, 2024
Please ensure you have read the [contribution docs](https://github.com/microsoft/mu/blob/master/CONTRIBUTING.md) prior to submitting the pull request. In particular, [pull request guidelines](https://github.com/microsoft/mu/blob/master/CONTRIBUTING.md#pull-request-best-practices). The current dTPM library instance only supports MM_STANDALONE, which makes the MM core module unable to use this instance. This change expands the support for this library to cover MM_CORE_STANDALONE as well. For each item, place an "x" in between `[` and `]` if true. Example: `[x]`. _(you can also check items in the GitHub UI)_ - [x] Impacts functionality? - **Functionality** - Does the change ultimately impact how firmware functions? - Examples: Add a new library, publish a new PPI, update an algorithm, ... - [ ] Impacts security? - **Security** - Does the change have a direct security impact on an application, flow, or firmware? - Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ... - [ ] Breaking change? - **Breaking change** - Will anyone consuming this change experience a break in build or boot behavior? - Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ... - [ ] Includes tests? - **Tests** - Does the change include any explicit test code? - Examples: Unit tests, integration tests, robot tests, ... - [ ] Includes documentation? - **Documentation** - Does the change contain explicit documentation additions outside direct code modifications (and comments)? - Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ... This was tested on QEMU Q35 and verified bootable to UEFI shell. N/A cherry-pick from 7f54cf0
cfernald
pushed a commit
to cfernald/mu_tiano_plus
that referenced
this pull request
Jul 23, 2024
Please ensure you have read the [contribution docs](https://github.com/microsoft/mu/blob/master/CONTRIBUTING.md) prior to submitting the pull request. In particular, [pull request guidelines](https://github.com/microsoft/mu/blob/master/CONTRIBUTING.md#pull-request-best-practices). The current dTPM library instance only supports MM_STANDALONE, which makes the MM core module unable to use this instance. This change expands the support for this library to cover MM_CORE_STANDALONE as well. For each item, place an "x" in between `[` and `]` if true. Example: `[x]`. _(you can also check items in the GitHub UI)_ - [x] Impacts functionality? - **Functionality** - Does the change ultimately impact how firmware functions? - Examples: Add a new library, publish a new PPI, update an algorithm, ... - [ ] Impacts security? - **Security** - Does the change have a direct security impact on an application, flow, or firmware? - Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ... - [ ] Breaking change? - **Breaking change** - Will anyone consuming this change experience a break in build or boot behavior? - Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ... - [ ] Includes tests? - **Tests** - Does the change include any explicit test code? - Examples: Unit tests, integration tests, robot tests, ... - [ ] Includes documentation? - **Documentation** - Does the change contain explicit documentation additions outside direct code modifications (and comments)? - Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ... This was tested on QEMU Q35 and verified bootable to UEFI shell. N/A cherry-pick from 7f54cf0
cfernald
pushed a commit
to cfernald/mu_tiano_plus
that referenced
this pull request
Jul 23, 2024
Please ensure you have read the [contribution docs](https://github.com/microsoft/mu/blob/master/CONTRIBUTING.md) prior to submitting the pull request. In particular, [pull request guidelines](https://github.com/microsoft/mu/blob/master/CONTRIBUTING.md#pull-request-best-practices). The current dTPM library instance only supports MM_STANDALONE, which makes the MM core module unable to use this instance. This change expands the support for this library to cover MM_CORE_STANDALONE as well. For each item, place an "x" in between `[` and `]` if true. Example: `[x]`. _(you can also check items in the GitHub UI)_ - [x] Impacts functionality? - **Functionality** - Does the change ultimately impact how firmware functions? - Examples: Add a new library, publish a new PPI, update an algorithm, ... - [ ] Impacts security? - **Security** - Does the change have a direct security impact on an application, flow, or firmware? - Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ... - [ ] Breaking change? - **Breaking change** - Will anyone consuming this change experience a break in build or boot behavior? - Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ... - [ ] Includes tests? - **Tests** - Does the change include any explicit test code? - Examples: Unit tests, integration tests, robot tests, ... - [ ] Includes documentation? - **Documentation** - Does the change contain explicit documentation additions outside direct code modifications (and comments)? - Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ... This was tested on QEMU Q35 and verified bootable to UEFI shell. N/A cherry-pick from 7f54cf0 Signed-off-by: kuqin12 <42554914+kuqin12@users.noreply.github.com>
cfernald
pushed a commit
that referenced
this pull request
Jul 23, 2024
Please ensure you have read the [contribution docs](https://github.com/microsoft/mu/blob/master/CONTRIBUTING.md) prior to submitting the pull request. In particular, [pull request guidelines](https://github.com/microsoft/mu/blob/master/CONTRIBUTING.md#pull-request-best-practices). The current dTPM library instance only supports MM_STANDALONE, which makes the MM core module unable to use this instance. This change expands the support for this library to cover MM_CORE_STANDALONE as well. For each item, place an "x" in between `[` and `]` if true. Example: `[x]`. _(you can also check items in the GitHub UI)_ - [x] Impacts functionality? - **Functionality** - Does the change ultimately impact how firmware functions? - Examples: Add a new library, publish a new PPI, update an algorithm, ... - [ ] Impacts security? - **Security** - Does the change have a direct security impact on an application, flow, or firmware? - Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ... - [ ] Breaking change? - **Breaking change** - Will anyone consuming this change experience a break in build or boot behavior? - Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ... - [ ] Includes tests? - **Tests** - Does the change include any explicit test code? - Examples: Unit tests, integration tests, robot tests, ... - [ ] Includes documentation? - **Documentation** - Does the change contain explicit documentation additions outside direct code modifications (and comments)? - Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ... This was tested on QEMU Q35 and verified bootable to UEFI shell. N/A cherry-pick from 7f54cf0 Signed-off-by: kuqin12 <42554914+kuqin12@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preface
Please ensure you have read the contribution docs prior
to submitting the pull request. In particular,
pull request guidelines.
Description
The current dTPM library instance only supports MM_STANDALONE, which makes the MM core module unable to use this instance.
This change expands the support for this library to cover MM_CORE_STANDALONE as well.
For each item, place an "x" in between
[and]if true. Example:[x].(you can also check items in the GitHub UI)
flow, or firmware?
validation improvement, ...
in build or boot behavior?
a function in a new library class in a pre-existing module, ...
outside direct code modifications (and comments)?
on an a separate Web page, ...
How This Was Tested
This was tested on QEMU Q35 and verified bootable to UEFI shell.
Integration Instructions
N/A