Update NNIManager.getTrialJob to contain all hyper parameters (#1288)

* Update NNIManager.getTrialJob
microsoft · Jul 18, 2019 · 227a461 · 227a461
1 parent 797f0e2
commit 227a461
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/src/nni_manager/core/nniDataStore.ts b/src/nni_manager/core/nniDataStore.ts
@@ -141,6 +141,7 @@ class NNIDataStore implements DataStore {
 
     public async getTrialJob(trialJobId: string): Promise<TrialJobInfo> {
         const trialJobs: TrialJobInfo[] = await this.queryTrialJobs(undefined, trialJobId);
+        assert(trialJobs.length <= 1);
 
         return trialJobs[0];
     }

diff --git a/src/nni_manager/core/nnimanager.ts b/src/nni_manager/core/nnimanager.ts
@@ -242,10 +242,8 @@ class NNIManager implements Manager {
         });
     }
 
-    public getTrialJob(trialJobId: string): Promise<TrialJobDetail> {
-        return Promise.resolve(
-            this.trainingService.getTrialJob(trialJobId)
-        );
+    public getTrialJob(trialJobId: string): Promise<TrialJobInfo> {
+        return this.dataStore.getTrialJob(trialJobId);
     }
 
     public async setClusterMetadata(key: string, value: string): Promise<void> {

diff --git a/src/nni_manager/core/test/mockedDatastore.ts b/src/nni_manager/core/test/mockedDatastore.ts
@@ -221,7 +221,12 @@ class MockedDataStore implements DataStore {
     }
 
     public getTrialJob(trialJobId: string): Promise<TrialJobInfo> {
-        throw new Error("Method not implemented.");
+        return Promise.resolve({
+            id: '1234',
+            status: 'SUCCEEDED',
+            startTime: Date.now(),
+            endTime: Date.now()
+        });
     }
 
     private async getFinalMetricData(trialJobId: string): Promise<any> {