Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

Remove Tuner's unnecessary ClassArg requirements #903

Closed
PurityFan opened this issue Mar 21, 2019 · 3 comments
Closed

Remove Tuner's unnecessary ClassArg requirements #903

PurityFan opened this issue Mar 21, 2019 · 3 comments
Assignees
Labels

Comments

@PurityFan
Copy link
Contributor

Currently Tuner has some ClassArg that is not necessary.

For example:
tuner: builtinTunerName: Random classArgs: optimize_mode: maximize

In fact, random doesn‘t need optimize_mode.
This option is required, that is to say, if you don't add this item, you will get an error.
This is neither reasonable nor affects the user experience. It is recommended to change to optional.

@xuehui1991
Copy link
Contributor

Good suggestion!

@xuehui1991 xuehui1991 self-assigned this Mar 22, 2019
@xuehui1991
Copy link
Contributor

#916 will fix this issue. Since we don't need to know the optimize_mode in random, remove "optimize_mode" in Random tuner.

xuehui1991 added a commit that referenced this issue Mar 27, 2019
* update readme in ga_squad

* update readme

* fix typo

* Update README.md

* Update README.md

* Update README.md

* update readme

* update

* fix path

* update reference

* fix bug in config file

* update nni_arch_overview.png

* update

* update

* update

* update home page

* fix issue: #902, random parameter

* update doc about random

* change Random tuner test

* update metric_test for Random tuner

* update random config in test

* update Evolution_SQuAD doc
@xuehui1991
Copy link
Contributor

Already merge into the master branch. Close this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants