This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Fix bug bash of import data feature #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuehui1991
reviewed
Apr 23, 2019
| @@ -139,6 +139,27 @@ def json2vals(in_x, vals, out_y, name=ROOT): | |||
| for i, temp in enumerate(in_x): | |||
| json2vals(temp, vals[i], out_y, name + '[%d]' % i) | |||
|
|
|||
| def nni_params2tuner_params(in_x, parameter): | |||
There was a problem hiding this comment.
the name of this function is a little weird? why we need the prefix "nni"?
There was a problem hiding this comment.
I also confuse the name of this function. This function converts the form of hyperparameters in NNI into the form in TPE tuner. Do you have any suggestions for the name of this function?
There was a problem hiding this comment.
Rename to "params2tuner_params"
PurityFan
changed the title
QuanluZhang
approved these changes
Apr 24, 2019
SparkSnail
approved these changes
Apr 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: add a conversion function to convert the parameter into an acceptable format in TPE