PAI quota management #1021
PAI quota management #1021
Conversation
fix remote bug (microsoft#523)
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
| * __nnictl hdfs set__ | ||
| * Description | ||
|
|
||
| set the host and userName of hdfs |
There was a problem hiding this comment.
please give simple example about what is the format of hdfs host
There was a problem hiding this comment.
given an example in the grid.
docs/en_US/Nnictl.md
Outdated
|
|
||
| * Description | ||
|
|
||
| Clean up all files created by nni in hdfs |
There was a problem hiding this comment.
better to make it more clear: Clean up the code files that nni automatically copied to hdfs. This command deletes all such files under the user_name.
There was a problem hiding this comment.
fixed, changed to use Clean up the code files that nni automatically copied to hdfs. This command deletes all such files under the user_name.
tools/nni_cmd/config_utils.py
Outdated
| return json.load(file) | ||
| except Exception: | ||
| return {} |
There was a problem hiding this comment.
the meaning of return {}?
There was a problem hiding this comment.
Return a None type or an empty dict if got error, changed to use None, more easy to understand.
| return json.load(file) | ||
| except Exception: | ||
| return None |
There was a problem hiding this comment.
exception should be logged.
| if hdfs_client.delete(full_path, recursive=True): | ||
| print_normal('delete success!') | ||
| else: | ||
| print_normal('delete failed!') |
There was a problem hiding this comment.
Is it possible to show why failed?
There was a problem hiding this comment.
Is it possible to use <root_path>/* ?
There was a problem hiding this comment.
Is it possible to use <root_path>/* ?
Yes, but we want to show the details of deleting process, so we do not delete root_path directly, instead we traverse the paths under root_path, and show the paths to users.
There was a problem hiding this comment.
Is it possible to show why failed?
No, this function return false if delete failed, but do not give error message and do not throw any exception.
Manage hdfs of PAI using nnictl, support listing files, downloading files and deleting files in hdfs.
#1050