Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

Update check_ready_to_run in windows local mode #1025

Merged
merged 6 commits into from
Apr 28, 2019
Merged

Update check_ready_to_run in windows local mode #1025

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8c9f1c6
Update mnist-hyperband.test.yml
demianzhang Apr 12, 2019
a418da5
Merge remote-tracking branch 'upstream/master' into patch-2
demianzhang Apr 23, 2019
57fb5a0
Fix system node
demianzhang Apr 23, 2019
62c4219
Fix pgrep in windows
demianzhang Apr 27, 2019
74ac12e
Merge remote-tracking branch 'upstream/v0.7' into dev-windows
demianzhang Apr 27, 2019
bd3a035
Fix comments
demianzhang Apr 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions tools/nni_gpu_tool/gpu_metrics_collector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,20 @@
from xml.dom import minidom

def check_ready_to_run():
#TODO check process in windows
if sys.platform == 'win32':
return True
pgrep_output =subprocess.check_output('pgrep -fx \'python3 -m nni_gpu_tool.gpu_metrics_collector\'', shell=True)
pidList = []
for pid in pgrep_output.splitlines():
pidList.append(int(pid))
pidList.remove(os.getpid())
return len(pidList) == 0
pgrep_output = subprocess.check_output('wmic process where "CommandLine like \'%nni_gpu_tool.gpu_metrics_collector%\' and name like \'%python%\'" get processId')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you describe the process and motivation of 'check ready to run'?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will check whether the nni_gpu_tool.gpu_metrics_collector is running or not excluding the self process. if it return false, it will not continue to get information and write to gpu_metrics.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it.

pidList = pgrep_output.decode("utf-8").strip().split()
pidList.pop(0) # remove the key word 'ProcessId'
pidList = list(map(int, pidList))
pidList.remove(os.getpid())
return len(pidList) == 0
else:
pgrep_output =subprocess.check_output('pgrep -fx \'python3 -m nni_gpu_tool.gpu_metrics_collector\'', shell=True)
pidList = []
for pid in pgrep_output.splitlines():
pidList.append(int(pid))
pidList.remove(os.getpid())
return len(pidList) == 0

def main(argv):
metrics_output_dir = os.environ['METRIC_OUTPUT_DIR']
Expand Down