This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Show error message when setClusterMetadata in kubeflow and frameworkcontroller #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix remote bug (microsoft#523)
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
Fix installation (microsoft#864)
merge master
merge master
merge master
merge master
Fix remote integration test pipeline (microsoft#914)
merge master
merge master
merge master
merge master
merge master
merge master
Add integration test for BOHB (microsoft#985)
merge master
Designated gpu devices for NNI trial jobs (microsoft#991)
merge master
Fix yaml package in setup.py (microsoft#1006)
merge master
merge master
QuanluZhang
approved these changes
May 13, 2019
chicm-ms
reviewed
May 14, 2019
| } catch(error) { | ||
| this.log.error(error); | ||
| return Promise.reject(new Error(error)); | ||
| } |
There was a problem hiding this comment.
I assume the problem is caused by that the type of error is string? if yes, the problem has been address by this PR, #1064 , it is not necessary to handle this issue case by case.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #1036