Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

Unified doc's name & update docs #1069

Merged
merged 4 commits into from
May 15, 2019
Merged

Conversation

PurityFan
Copy link
Contributor

@PurityFan PurityFan commented May 12, 2019

  1. Fix issue Unable to open webUI link #1063
  2. Unified doc's name:
  • For .md file, use the uppercase for initial letters, no spacers. For example BuiltinTuners.md, BatchTuner.md
  • For .rst file, use lowercase for all letters and unferline "_" as a spacer. For example index.rst, training_services.rst, sdk_reference.rst
  • Treat all abbreviate words as one word. For example, PaiMode.md, SquadEvolutionExamples.md

@PurityFan PurityFan changed the title update docs for can not open WebUI link Unified doc's name & update docs May 12, 2019
@@ -157,7 +157,7 @@ Run the **config_windows.yml** file from your command line to start MNIST experi
nnictl create --config nni/examples/trials/mnist/config_windows.yml
```

Note, **nnictl** is a command line tool, which can be used to control experiments, such as start/stop/resume an experiment, start/stop NNIBoard, etc. Click [here](NNICTLDOC.md) for more usage of `nnictl`
Note, **nnictl** is a command line tool, which can be used to control experiments, such as start/stop/resume an experiment, start/stop NNIBoard, etc. Click [here](Nnictl.md) for more usage of `nnictl`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Nnictl" seems a little weird....

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for a unified doc's name.
For .md file, we use the uppercase for initial letters, no spacers. For example BuiltinTuners.md, BatchTuner.md.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand. But can we have an exception for "NNI"? How about "NNIctl.md"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We "Treat all abbreviate words as one word. For example, PaiMode.md, SquadEvolutionExamples.md", have an exception for "NNI" maybe not a standard use?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think either one is okay. Since this is only file name, users would not care too much about it, let's simply unify the format, i.e., using 'Nni'?

@QuanluZhang
Copy link
Contributor

Thanks for unifying the format of files' names.

@PurityFan
Copy link
Contributor Author

@leckie-chn @squirrelsc please help review~

@QuanluZhang QuanluZhang merged commit bc0e55a into microsoft:master May 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants