This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
import finished trial data to tuner when experiment is resumed #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuanluZhang
requested review from
leckie-chn,
Crysple,
xuehui1991,
chicm-ms,
SparkSnail and
yds05
xuehui1991
reviewed
May 27, 2019
tools/nni_cmd/nnictl_utils.py
Outdated
| with open(args.path, 'w') as file: | ||
| if args.type == 'csv': | ||
| writer = csv.DictWriter(file, set.union(*[set(r.keys()) for r in records])) | ||
| f_obj = open(args.path, 'w') |
There was a problem hiding this comment.
suggest using "with open(...) as file" to make sure you have the same style with line 279.
There was a problem hiding this comment.
good suggestion.
chicm-ms
approved these changes
May 27, 2019
leckie-chn
reviewed
May 27, 2019
leckie-chn
approved these changes
May 27, 2019
SparkSnail
approved these changes
May 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.