This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Fix EMFILE error in local training service #1189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix remote bug (microsoft#523)
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master from Microsoft
merge master
merge V0.8
merge master
Add sklearn installation in setup.py (microsoft#1157)
merge master
merge master
merge master
chicm-ms
approved these changes
Jun 21, 2019
QuanluZhang
approved these changes
Jun 21, 2019
xuehui1991
approved these changes
Jun 23, 2019
QuanluZhang
reviewed
Jun 24, 2019
| @@ -355,7 +355,8 @@ class LocalTrainingService implements TrainingService { | |||
| this.log.info('Stopping local machine training service...'); | |||
| this.stopping = true; | |||
| for (const stream of this.jobStreamMap.values()) { | |||
| stream.destroy(); | |||
| stream.end(0) | |||
There was a problem hiding this comment.
could be better to add the github issue. what do you think @chicm-ms @SparkSnail ?
There was a problem hiding this comment.
As discussed with @chicm-ms , I've add related issue in code.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue: #867
Refer: Juul/tail-stream#20