This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Run flake8 tests to find Python syntax errors and undefined names #1217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuehui1991
reviewed
Jun 27, 2019
azure-pipelines.yml
Outdated
| @@ -13,6 +13,10 @@ jobs: | |||
| - script: | | |||
| source install.sh | |||
| displayName: 'Install nni toolkit via source code' | |||
| - script: | | |||
| python3 -m pip install flake8 | |||
| flake8 . --count --select=E9,F63,F72,F82 --show-source --statistics | |||
There was a problem hiding this comment.
you may need to add "--user"
|
@cclauss Thanks for contributing this PR. The rest errors can be fixed soon, we will merge this PR after the errors are fixed. |
|
@cclauss The ignore config |
chicm-ms
reviewed
Jul 2, 2019
azure-pipelines.yml
Outdated
| @@ -13,6 +13,11 @@ jobs: | |||
| - script: | | |||
| source install.sh | |||
| displayName: 'Install nni toolkit via source code' | |||
| - script: | | |||
| python3 -m pip install flake8 --user | |||
| IGNORE=./tools/nni_annotation/testcase:F821,./examples/trials/mnist-nas/mnist.py:F821 | |||
There was a problem hiding this comment.
just checked locally, should change to --per-file-ignores
--per-file-ignores ./tools/nni_annotation/*:F821,./examples/trials/mnist-nas/mnist.py:F821
|
@cclauss Thanks, the ignore config is working now. |
44 tasks
chicm-ms
approved these changes
Jul 10, 2019
xuehui1991
approved these changes
Jul 10, 2019
66 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.