#1286 Re submit #1358

suiguoxin · 2019-07-24T02:24:04Z

only failed jobs can be re-submitted
no trial_id returned when re-submitted successfully
else raise err

xuehui1991 · 2019-07-25T04:58:07Z

src/nni_manager/core/nniDataStore.ts

@@ -141,6 +141,7 @@ class NNIDataStore implements DataStore {

    public async getTrialJob(trialJobId: string): Promise<TrialJobInfo> {
        const trialJobs: TrialJobInfo[] = await this.queryTrialJobs(undefined, trialJobId);
+        assert(trialJobs.length <= 1);


if trialJobs.length == 0, then asseration is right but will crash when take value "trialJobs[0]" ?

Here is to avoid confict with this PR #1288. I don't know exactly why this assert is added @chicm-ms

liuzhe-lz · 2019-07-25T07:17:42Z

src/sdk/pynni/nni/msg_dispatcher_base.py

@@ -168,6 +169,9 @@ def handle_initialize(self, data):
    def handle_request_trial_jobs(self, data):
        raise NotImplementedError('handle_request_trial_jobs not implemented')

+    def handle_resubmit_trial_job(self, data):
+        raise NotImplementedError('handle_resubmit_trial_job not implemented')
+
    def handle_update_search_space(self, data):
       raise NotImplementedError('handle_update_search_space not implemented')


Irrelevant to this PR. The indentation is mistyped.

why irrelevant ? Which indentation ?

chicm-ms · 2019-07-26T02:58:22Z

src/nni_manager/common/manager.ts

@@ -103,6 +103,7 @@ abstract class Manager {
    public abstract exportData(): Promise<string>;

    public abstract addCustomizedTrialJob(hyperParams: string): Promise<void>;
+    public abstract resubmitTrialJob(hyperParams: string): Promise<void>;
    public abstract cancelTrialJobByUser(trialJobId: string): Promise<void>;


the parameter should be trial job id as we discussed.

chicm-ms · 2019-07-26T02:59:38Z

src/nni_manager/core/nnimanager.ts

@@ -135,6 +135,42 @@ class NNIManager implements Manager {
        return this.dataStore.storeTrialJobEvent('ADD_CUSTOMIZED', '', hyperParams);
    }

+    public async resubmitTrialJob(data: string): Promise<void> {
+        // get trail job info by jobId
+        const trialJobId = JSON.parse(data).job_id


The parameter should be trial job id, it should not need to be parsed inside this function.

chicm-ms · 2019-07-26T03:01:41Z

src/nni_manager/core/nnimanager.ts

+            return Promise.reject(
+                new Error('only failed trials can be resubmitted')
+            );
+        }


This status checking can be moved up to before retrieving hyperParameter.

suiguoxin added 3 commits July 11, 2019 19:15

add re-submit process

7107f94

runnable resubmit

286a247

add trialJob status check

80e9e23

suiguoxin requested review from chicm-ms and lvybriage July 24, 2019 03:43

lvybriage approved these changes Jul 24, 2019

View reviewed changes

QuanluZhang requested review from xuehui1991, leckie-chn, liuzhe-lz and SparkSnail July 25, 2019 00:47

xuehui1991 reviewed Jul 25, 2019

View reviewed changes

liuzhe-lz reviewed Jul 25, 2019

View reviewed changes

chicm-ms reviewed Jul 26, 2019

View reviewed changes

suiguoxin added 3 commits July 27, 2019 17:59

change function parameter; move up err check

f36b9db

Merge branch 'master' into re-submit

623a777

fix indentation

60ef46f

QuanluZhang closed this Sep 6, 2019

suiguoxin deleted the re-submit branch November 13, 2019 06:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#1286 Re submit #1358

#1286 Re submit #1358

suiguoxin commented Jul 24, 2019

xuehui1991 Jul 25, 2019

suiguoxin Jul 27, 2019 •

edited

Loading

liuzhe-lz Jul 25, 2019

suiguoxin Jul 27, 2019

suiguoxin Jul 29, 2019

chicm-ms Jul 26, 2019

suiguoxin Jul 27, 2019

chicm-ms Jul 26, 2019

suiguoxin Jul 27, 2019

chicm-ms Jul 26, 2019 •

edited

Loading

suiguoxin Jul 27, 2019

#1286 Re submit #1358

#1286 Re submit #1358

Conversation

suiguoxin commented Jul 24, 2019

Choose a reason for hiding this comment

suiguoxin Jul 27, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chicm-ms Jul 26, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

suiguoxin Jul 27, 2019 •

edited

Loading

chicm-ms Jul 26, 2019 •

edited

Loading