This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Add intermediate count column to show trial progress #1408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuanluZhang
reviewed
Aug 5, 2019
QuanluZhang
reviewed
Aug 5, 2019
liuzhe-lz
reviewed
Aug 5, 2019
| } else { | ||
| flagKill = false; | ||
| } | ||
| const flag: boolean = trialStatus === 'RUNNING' ? false : true; |
There was a problem hiding this comment.
const flag: boolean = (trialStatus !== 'RUNNING');
liuzhe-lz
reviewed
Aug 5, 2019
| // placeholder="range" | ||
| ref={input => this.minValInput = input} | ||
| /> | ||
| <span className="heng">-</span> |
QuanluZhang
reviewed
Aug 5, 2019
| } | ||
| }); | ||
| showTitle = COLUMN.concat(want); | ||
| if (item.length <= 1) { |
There was a problem hiding this comment.
could add comments here to explain why check whether item.length is smaller than 1
There was a problem hiding this comment.
maybe have some questions... I'll test an experiment with dic final keys.
QuanluZhang
reviewed
Aug 5, 2019
| } else { | ||
| flagKill = false; | ||
| } | ||
| const flag: boolean = trialStatus === 'RUNNING' ? false : true; |
There was a problem hiding this comment.
code refactor, or logic change?
There was a problem hiding this comment.
It's code refactor.
liuzhe-lz
reviewed
Aug 5, 2019
| if (item[key] !== 'default') { | ||
| want.push(item[key]); | ||
| } | ||
| }); |
There was a problem hiding this comment.
item.forEach(value => {
if (value !== 'default') {
want.push(value);
}
});
QuanluZhang
approved these changes
Aug 5, 2019
liuzhe-lz
approved these changes
Aug 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related changes: