This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
change authFile to local path #1455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuanluZhang
reviewed
Aug 12, 2019
| @@ -54,7 +54,7 @@ Compared with [LocalMode](LocalMode.md) and [RemoteMachineMode](RemoteMachineMod | |||
| * shmMB | |||
| * Optional key. Set the shmMB configuration of OpenPAI, it set the shared memory for one task in the task role. | |||
| * authFile | |||
| * Optional key, Set the auth file path for private registry while using PAI mode, [Refer](https://github.com/microsoft/pai/blob/2ea69b45faa018662bc164ed7733f6fdbb4c42b3/docs/faq.md#q-how-to-use-private-docker-registry-job-image-when-submitting-an-openpai-job). | |||
| * Optional key, Set the auth file path for private registry while using PAI mode, [Refer](https://github.com/microsoft/pai/blob/2ea69b45faa018662bc164ed7733f6fdbb4c42b3/docs/faq.md#q-how-to-use-private-docker-registry-job-image-when-submitting-an-openpai-job), the value should be a valid local authFile path. | |||
There was a problem hiding this comment.
, the value should be a valid local authFile path ==> , you can prepare the authFile and simply provide the local path of this file, NNI will upload this file to HDFS for you.
QuanluZhang
reviewed
Aug 12, 2019
| @@ -436,7 +436,20 @@ class PAITrainingService implements TrainingService { | |||
| this.paiTrialConfig.shmMB, | |||
| ) | |||
| ]; | |||
| // Upload authFile to hdfs | |||
| let authFileHdfsDir: string | undefined = undefined; | |||
There was a problem hiding this comment.
I think this logic should be included in setclustermetadata, but this field is within trialconfig....
liuzhe-lz
reviewed
Aug 12, 2019
| @@ -54,7 +54,7 @@ Compared with [LocalMode](LocalMode.md) and [RemoteMachineMode](RemoteMachineMod | |||
| * shmMB | |||
| * Optional key. Set the shmMB configuration of OpenPAI, it set the shared memory for one task in the task role. | |||
| * authFile | |||
| * Optional key, Set the auth file path for private registry while using PAI mode, [Refer](https://github.com/microsoft/pai/blob/2ea69b45faa018662bc164ed7733f6fdbb4c42b3/docs/faq.md#q-how-to-use-private-docker-registry-job-image-when-submitting-an-openpai-job). | |||
| * Optional key, Set the auth file path for private registry while using PAI mode, [Refer](https://github.com/microsoft/pai/blob/2ea69b45faa018662bc164ed7733f6fdbb4c42b3/docs/faq.md#q-how-to-use-private-docker-registry-job-image-when-submitting-an-openpai-job), you can prepare the authFile and simply provide the local path of this file, NNI will upload this file to HDFS for you. | |||
liuzhe-lz
approved these changes
Aug 12, 2019
QuanluZhang
approved these changes
Aug 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.