This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Remove unneccessary dependencies in pipeline #1597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chicm-ms
requested review from
SparkSnail,
QuanluZhang,
liuzhe-lz and
xuehui1991
chicm-ms
changed the title
QuanluZhang
reviewed
Oct 10, 2019
| python3 -m pip install torch==0.4.1 --user | ||
| python3 -m pip install torchvision==0.2.1 --user | ||
| python3 -m pip install keras==2.1.6 --user | ||
| python3 -m pip install tensorflow==1.12.0 --user |
There was a problem hiding this comment.
these packages are not necessary any more or installed at somewhere else?
There was a problem hiding this comment.
They are not necessary at all, the test trial jobs are running on remote kubeflow training service. These dependencies are installed on local kubeflow client (nnimanager).
There was a problem hiding this comment.
Seems this installs dependencies to host environment but the trials are running in container?
If that's the case, then I got it.nnictl package install are also unnecessary?
liuzhe-lz
approved these changes
Oct 10, 2019
QuanluZhang
approved these changes
Oct 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.