This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Allow serializing NaN in SDK #1711
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this change may break nniDataStore and webui. |
chicm-ms
approved these changes
Nov 12, 2019
|
Implemented in PR #1958 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found
json_trickshas a parameterallow_nan, which can hopefully solve issue #1589 .But this may introduce other problems, because NaN is not part of JSON standard and cannot be deserialized in major browsers or Node.js.
Update: Maybe we can use JSON5 in TypeScript side. However our JSONs can be really large so we should assess its performance before using it.
The pipeline failed for "cannot find module sqlite3". Seems we have some version problems again. @chicm-ms