This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Api refactor #1728
Merged
Api refactor #1728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuzhe-lz
reviewed
Nov 11, 2019
liuzhe-lz
reviewed
Nov 11, 2019
QuanluZhang
approved these changes
Nov 11, 2019
xuehui1991
reviewed
Nov 12, 2019
| output that needs to be quantized | ||
| config : dict | ||
| the configuration for output quantization | ||
| """ |
There was a problem hiding this comment.
Oh, I follow the quantize_weight format. This means user needs to return a tensor, which is the quantized output.
There was a problem hiding this comment.
OK. At least add ...here?
There was a problem hiding this comment.
Sure. ... will make more sense.
There was a problem hiding this comment.
I add a comment
# Put your code to generate `new_input` here
return new_inputI think this will be more clear.
liuzhe-lz
approved these changes
Nov 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.