This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Gradient Feature Selection (Ready to review) #1734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuehui1991
changed the title
xuehui1991
changed the title
xuehui1991
requested review from
chicm-ms,
QuanluZhang,
liuzhe-lz,
leckie-chn,
yangmao99 and
scarlett2018
xuehui1991
changed the title
chicm-ms
reviewed
Nov 20, 2019
src/sdk/pynni/nni/feature_engineering/gradient_selector/fgtrain.py
Outdated
Show resolved
Hide resolved
chicm-ms
reviewed
Nov 21, 2019
chicm-ms
reviewed
Nov 21, 2019
chicm-ms
reviewed
Nov 21, 2019
chicm-ms
reviewed
Nov 21, 2019
chicm-ms
approved these changes
Nov 21, 2019
QuanluZhang
reviewed
Nov 21, 2019
examples/trials/feature-selection/gbdt_selector/gbdt_selector_test.py
Outdated
Show resolved
Hide resolved
QuanluZhang
reviewed
Nov 21, 2019
QuanluZhang
reviewed
Nov 21, 2019
src/sdk/pynni/nni/feature_engineering/gradient_selector/requirements.txt
Outdated
Show resolved
Hide resolved
|
better to add unit test in this pr or another pr |
QuanluZhang
reviewed
Nov 22, 2019
| @@ -0,0 +1,3 @@ | |||
| # FeatureEngineering | |||
|
|
|||
| We are glad to announce the alpha release for Feature Engineering toolkit on top of NNI, it's still in the experiment phase which might evolve based on usage feedback. We'd like to invite you to use, feedback and even contribute. | |||
There was a problem hiding this comment.
better to give more description, the design, supported algorithms, etc.
QuanluZhang
approved these changes
Nov 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including two feature selector:
May refine docs in the future.