This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
add dataZoom for graph #1736
Merged
add dataZoom for graph #1736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's more useful to have y-zoom instead of x-zoom in "Intermediate result", if supporting both is difficult. As for "default metric" and "trial duration", why bother? |
ultmaster
approved these changes
Nov 20, 2019
liuzhe-lz
reviewed
Nov 21, 2019
| @@ -12,7 +12,7 @@ | |||
| "copy-to-clipboard": "^3.0.8", | |||
| "css-loader": "0.28.7", | |||
| "dotenv": "^8.0.0", | |||
| "echarts": "^4.1.0", | |||
| "echarts": "^4.5.0", | |||
There was a problem hiding this comment.
You need to commit yarn.lock.
liuzhe-lz
reviewed
Nov 25, 2019
| @@ -5,34 +5,29 @@ | |||
| "@ant-design/icons-react@~1.1.2": | |||
| version "1.1.5" | |||
| resolved "https://registry.yarnpkg.com/@ant-design/icons-react/-/icons-react-1.1.5.tgz#1b03da8dcced2a4bb982ef7b25c1d24014c35a68" | |||
| integrity sha512-p2ybKfO/r2lC1RZu4rDY2VBDZq2zqAaJzf/B1HrKTxGo8/mM1zOOEoob/LRXZphJ9jD5wCcTdcmcB9YMaAWW4Q== | |||
There was a problem hiding this comment.
The PR is okay but I suggest you to upgrade your yarn version.
liuzhe-lz
approved these changes
Nov 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please help review this PR.