This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
[NAS] simplify log, and fix a bug on pdarts exporting #1777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuehui1991
reviewed
Nov 25, 2019
| fmt = '[%(asctime)s] %(levelname)s (%(name)s/%(threadName)s) %(message)s' | ||
| logging.Formatter.converter = time.localtime | ||
| formatter = logging.Formatter(fmt, '%m/%d/%Y, %I:%M:%S %p') | ||
| logger = logging.getLogger('nni') |
There was a problem hiding this comment.
It's root logger of the code, and nni logger is initialized, so it set to nni logger here.
| std_out_info.setFormatter(formatter) | ||
| logger.setLevel(logging.INFO) | ||
| logger.addHandler(std_out_info) | ||
| logger = logging.getLogger('nni') |
squirrelsc
changed the title
QuanluZhang
reviewed
Nov 26, 2019
examples/nas/darts/search.py
Outdated
| @@ -7,20 +7,11 @@ | |||
|
|
|||
| import datasets | |||
| from model import CNN | |||
| from nni.nas.pytorch.callbacks import ArchitectureCheckpoint, LRSchedulerCallback | |||
| from nni.nas.pytorch.callbacks import (ArchitectureCheckpoint, LRSchedulerCallback) | |||
There was a problem hiding this comment.
why use brackets here?
QuanluZhang
approved these changes
Nov 26, 2019
chicm-ms
approved these changes
Nov 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.