This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuanluZhang
reviewed
Nov 28, 2019
Comments in teams. |
whether to remove these following document
|
xuehui1991
reviewed
Dec 2, 2019
xuehui1991
approved these changes
Dec 9, 2019
QuanluZhang
reviewed
Dec 9, 2019
QuanluZhang
reviewed
Dec 9, 2019
QuanluZhang
reviewed
Dec 9, 2019
@@ -87,7 +87,7 @@ We ran these two examples on the same machine with following details: | |||
|
|||
The detailed experiment results are shown in the below figure. Horizontal axis is sequential order of trials. Vertical axis is the metric, write OPS in this example. Blue dots represent trials for tuning RocksDB with SMAC tuner, and orange dots stand for trials for tuning RocksDB with TPE tuner. | |||
|
|||
![image](../../../examples/trials/systems/rocksdb-fillrandom/plot.png) | |||
![image](https://github.com/microsoft/nni/tree/master/examples/trials/systems/rocksdb-fillrandom/plot.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
which warning is it for this fix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deadlink warning.
QuanluZhang
reviewed
Dec 9, 2019
QuanluZhang
approved these changes
Dec 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WARNINGs left:
For docstring formatting, please refer to
nni.msg_dispatcher_base.MsgDispatcherBase.handle_request_trial_jobs
where I wrote an example about how to format the docstring better. @xuehui1991