This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Refactor dispatcher cmdline #1862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactor dispatcher command line
chicm-ms
requested review from
QuanluZhang,
liuzhe-lz,
SparkSnail and
ultmaster
ultmaster
reviewed
Dec 19, 2019
| def _run_advisor(args): | ||
| if args.advisor_class_name in AdvisorModuleName: | ||
| def _run_advisor(exp_params): | ||
| if exp_params.get('advisor').get('builtinAdvisorName') in AdvisorModuleName: |
There was a problem hiding this comment.
If exp_params.get('advisor') can be None, I think get won't help. Should write exp_params['advisor'] anyway.
There was a problem hiding this comment.
Here the key 'advisor' must exist, it is OK to use either exp_params['advisor'] or exp_params.get('advisor'), just want to be consistent with other places where key may not exists.
44 tasks
ultmaster
approved these changes
Dec 20, 2019
QuanluZhang
reviewed
Dec 21, 2019
| @@ -14,7 +14,9 @@ | |||
| 'send_metric', | |||
| ] | |||
|
|
|||
| init_standalone_logger() | |||
| if trial_env_vars.NNI_PLATFORM is None: | |||
| init_standalone_logger() | |||
There was a problem hiding this comment.
this file is for standalone mode, trial_env_vars.NNI_PLATFORM must be None, right?
There was a problem hiding this comment.
Good catch, the problem is on environment variables, NNI_PLATFORM is an env var for trial not for dispatcher, I will fix it in another PR.
QuanluZhang
approved these changes
Dec 23, 2019
19 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passthrough experiment settings to dispatcher, remove the unnecessary configuration parsing in nni manager.
Also fix following issue:
recognize customized tuner as builtin tuner if class name is same as one of builtin tuners.