This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scarlett2018
requested review from
chicm-ms
and removed request for
chicm-ms
February 24, 2020 02:41
35 tasks
SparkSnail
requested review from
chicm-ms,
liuzhe-lz,
1qt314,
QuanluZhang and
ultmaster
and removed request for
1qt314
February 26, 2020 12:23
chicm-ms
approved these changes
Feb 27, 2020
ultmaster
reviewed
Feb 27, 2020
test/generate_ts_config.py
Outdated
@@ -94,6 +111,10 @@ def convert_command(): | |||
parser.add_argument("--data_dir", type=str) | |||
parser.add_argument("--output_dir", type=str) | |||
parser.add_argument("--vc", type=str) | |||
parser.add_argument("--pai_token", type=str) | |||
parser.add_argument("--paiStoragePlugin", type=str) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggest pai_storage_plugin
, nni_manager_nfs...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
|
||
PATH=$HOME/.local/bin:$PATH python3 config_test.py --ts pai | ||
PATH=$HOME/.local/bin:$PATH python3 config_test.py --ts pai --exclude multi_phase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why exclude multi phase?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
paiK8STrainingService does not support multi phase now, maybe will support in next release.
ultmaster
approved these changes
Feb 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.