This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
improve windows install scripts #2470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
squirrelsc
commented
May 21, 2020
squirrelsc
commented
- Reduce error message if deleted folder not exists.
- Reduce unneccessary messages.
- Organize logic better for reinstall scenario.
SparkSnail
reviewed
Jun 8, 2020
| @@ -51,7 +51,7 @@ else { | |||
| $PIP_INSTALL = """$NNI_PYTHON3\python"" -m pip install " | |||
|
|
|||
| if (!(Test-Path $NNI_DEPENDENCY_FOLDER)) { | |||
| New-Item $NNI_DEPENDENCY_FOLDER -ItemType Directory | |||
| $null = New-Item $NNI_DEPENDENCY_FOLDER -ItemType Directory | |||
There was a problem hiding this comment.
The original command, New-Item $NNI_DEPENDENCY_FOLDER -ItemType Directory, will output command result to console. The default output is like below, if there are a lot of this kind of information, it buries important information. Use $null can put stdout to null pipeline. If there is error, it can show on screen as red text also, not be send to null pipeline.
Directory: D:\temp
Mode LastWriteTime Length Name
---- ------------- ------ ----
d----- 6/8/2020 11:30 AM test1
SparkSnail
reviewed
Jun 8, 2020
| New-Item -ItemType Junction -Path $($NNI_PKG_FOLDER_STATIC) -Target "src\webui\build" | ||
| New-Item -ItemType Junction -Path $($NASUI_PKG_FOLDER) -Target "src\nasui\build" | ||
| $null = New-Item -ItemType Junction -Path $NNI_PKG_FOLDER -Target "src\nni_manager\dist" | ||
|
|
SparkSnail
approved these changes
Jun 8, 2020
liuzhe-lz
approved these changes
Jun 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.