Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

remove optimize_mode from curve fitting #2471

Merged
merged 2 commits into from
Jun 5, 2020
Merged

remove optimize_mode from curve fitting #2471

merged 2 commits into from
Jun 5, 2020

Conversation

squirrelsc
Copy link
Member

others

  1. fix failed curve fitting UTs, due to code changes.
  2. move all SDK UTs to tests folder, so that they can be run in default tests.
  3. fix some deprecated ut assert function calls.

QuanluZhang
QuanluZhang approved these changes Jun 1, 2020
View reviewed changes
Copy link
Contributor

@QuanluZhang QuanluZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@QuanluZhang QuanluZhang requested a review from liuzhe-lz June 1, 2020 00:50
@squirrelsc squirrelsc merged commit e75a9f5 into microsoft:master Jun 5, 2020
@squirrelsc squirrelsc deleted the remove-curvefitting-min branch June 5, 2020 07:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@liuzhe-lz liuzhe-lz liuzhe-lz approved these changes

@QuanluZhang QuanluZhang QuanluZhang approved these changes

@xuehui1991 xuehui1991 Awaiting requested review from xuehui1991

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@squirrelsc @QuanluZhang @liuzhe-lz