Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

Fix bugs in NAS UI (deferred from previous releases) #2552

Merged
merged 5 commits into from
Jun 28, 2020

Conversation

ultmaster
Copy link
Contributor

  1. Add tooltips for buttons
  2. Fix issue when an edge is shared by multiple mutables
  3. Auto-fit graph at initialization
  4. Add unit-tests

@chicm-ms chicm-ms self-requested a review June 12, 2020 08:37
@@ -0,0 +1,26 @@
import { Graph } from './graphUtils';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest to move all unit test stuff into test directory like nnimanager.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the reference.

Jest will look for test files with any of the following popular naming conventions:

  • Files with .js suffix in __tests__ folders.
  • Files with .test.js suffix.
  • Files with .spec.js suffix.
    The .test.js / .spec.js files (or the tests folders) can be located at any depth under the src top level folder.

We recommend to put the test files (or tests folders) next to the code they are testing so that relative imports appear shorter. For example, if App.test.js and App.js are in the same folder, the test only needs to import App from './App' instead of a long relative path. Collocation also helps find tests more quickly in larger projects.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll move them to __tests__ folder. I checked nni manager conversion (test folder) and jest doesn't recognize them automatically.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, nnimanager is using mocha for test, what is the reason that nasui select jest instead of mocha?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used the default settings provided by react-scripts.

@ultmaster ultmaster merged commit 67ea330 into microsoft:master Jun 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants