This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Support nested experiment more friendly #2554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 tasks
|
liuzhe-lz
reviewed
Jun 19, 2020
| @@ -2,7 +2,7 @@ import * as React from 'react'; | |||
| import ReactEcharts from 'echarts-for-react'; | |||
| import { filterByStatus } from '../../static/function'; | |||
| import { EXPERIMENT } from '../../static/datamodel'; | |||
| import { Stack, PrimaryButton, Dropdown, IDropdownOption, } from 'office-ui-fabric-react'; // eslint-disable-line no-unused-vars | |||
| import { Stack, PrimaryButton, Dropdown, IDropdownOption } from 'office-ui-fabric-react'; // eslint-disable-line no-unused-vars | |||
There was a problem hiding this comment.
Why is the eslint-disable needed?
There was a problem hiding this comment.
Will delete eslint note now.
liuzhe-lz
reviewed
Jun 19, 2020
| let paraYdata: number[][] = []; | ||
| const { isNested } = this.state; | ||
| if (isNested === false) { | ||
| Object.keys(eachTrialParams).map(item => { |
There was a problem hiding this comment.
I think for ... of loop should be prefered if the return value is not used.
There was a problem hiding this comment.
Agreed. foreach(item => ... is also better
ultmaster
reviewed
Jun 19, 2020
| Object.keys(eachTrialParams).map(item => { | ||
| const temp: number[] = []; | ||
| for (let i = 0; i < dimName.length; i++) { | ||
| // if ('type' in parallelAxis[i]) { |
There was a problem hiding this comment.
Remove unused comments here.
ultmaster
approved these changes
Jun 20, 2020
liuzhe-lz
approved these changes
Jun 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issue #2513
now only support
choicetypedemo: http://13.77.78.63:9090/detail