This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Check eth0 in nnictl #2566
Merged
Check eth0 in nnictl #2566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge master
merge master
merge master
merge master
QuanluZhang
reviewed
Jun 17, 2020
| @@ -297,10 +298,19 @@ def validate_pai_trial_conifg(experiment_config): | |||
| print_warning(warning_information.format('outputDir')) | |||
| validate_pai_config_path(experiment_config) | |||
|
|
|||
| def validate_eth0_device(experiment_config): | |||
There was a problem hiding this comment.
do we need to remove the previous validation code?
There was a problem hiding this comment.
no, the previous code is used in nniManager, it is used to get ip address and not only for validation, they are two independent logic. In nniManager's code, it is normal to throw error when can not get os.networkInterfaces().eth0 as an independent function.https://github.com/microsoft/nni/blob/master/src/nni_manager/common/utils.ts#L219
ultmaster
approved these changes
Jun 19, 2020
QuanluZhang
approved these changes
Jun 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.