This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Eject docker usages in NAS benchmarks #2645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuanluZhang
approved these changes
Jul 6, 2020
JunweiSUN
reviewed
Jul 7, 2020
Comment on lines
3
to
8
| echo "Downloading NAS-Bench-101..." | ||
| wget https://storage.googleapis.com/nasbench/nasbench_full.tfrecord | ||
|
|
||
| echo "Generating database..." | ||
| rm -f /outputs/nasbench101.db /outputs/nasbench101.db-journal | ||
| NASBENCHMARK_DIR=/outputs python -m nni.nas.benchmarks.nasbench101.db_gen nasbench_full.tfrecord | ||
| rm -f ${NASBENCHMARK_DIR}/nasbench101.db ${NASBENCHMARK_DIR}/nasbench101.db-journal | ||
| python -m nni.nas.benchmarks.nasbench101.db_gen nasbench_full.tfrecord |
There was a problem hiding this comment.
wget -P ${NASBENCHMARK_DIR} https://storage.googleapis.com/nasbench/nasbench_full.tfrecord
python -m nni.nas.benchmarks.nasbench101.db_gen ${NASBENCHMARK_DIR}/nasbench_full.tfrecord
Would this be better since someone may run this script in other directory instead of examples/nas/benchmarks?
BTW, should we check if ${NASBENCHMARK_DIR} is empty and if so specific ${NASBENCHMARK_DIR} to ~/.nni/nasbenchmark at the beginning of this script and generate this directory?
There was a problem hiding this comment.
We can mkdir if it does not exist.
The tfrecord will not be used any more after generation. I should delete them right after the generation. And I'm against saving temporary files under NASBENCHMARK_DIR.
Comment on lines
3
to
8
| echo "Downloading NAS-Bench-201..." | ||
| gdown https://drive.google.com/uc\?id\=1OOfVPpt-lA4u2HJrXbgrRd42IbfvJMyE -O a.pth | ||
|
|
||
| echo "Generating database..." | ||
| rm -f /outputs/nasbench201.db /outputs/nasbench201.db-journal | ||
| NASBENCHMARK_DIR=/outputs python -m nni.nas.benchmarks.nasbench201.db_gen a.pth | ||
| rm -f ${NASBENCHMARK_DIR}/nasbench201.db ${NASBENCHMARK_DIR}/nasbench201.db-journal | ||
| python -m nni.nas.benchmarks.nasbench201.db_gen a.pth |
There was a problem hiding this comment.
same here.
gdown https://drive.google.com/uc\?id\=1OOfVPpt-lA4u2HJrXbgrRd42IbfvJMyE -O ${NASBENCHMARK_DIR}/a.pth
python -m nni.nas.benchmarks.nasbench201.db_gen ${NASBENCHMARK_DIR}/a.pth
examples/nas/benchmarks/nds.sh
Outdated
Comment on lines
4
to
9
| wget https://dl.fbaipublicfiles.com/nds/data.zip -O data.zip | ||
| unzip data.zip | ||
|
|
||
| echo "Generating database..." | ||
| rm -f /outputs/nds.db /outputs/nds.db-journal | ||
| NASBENCHMARK_DIR=/outputs python -m nni.nas.benchmarks.nds.db_gen nds_data | ||
| rm -f ${NASBENCHMARK_DIR}/nds.db ${NASBENCHMARK_DIR}/nds.db-journal | ||
| python -m nni.nas.benchmarks.nds.db_gen nds_data |
JunweiSUN
approved these changes
Jul 7, 2020
|
change documentation PR to #2651 |
chicm-ms
approved these changes
Jul 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@JunweiSUN will do the documentation. #2647