This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
[v1.8 bug-bash] fix webui error #2808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 20, 2020 15:37
colorjam
reviewed
Aug 21, 2020
| <LogPathChild | ||
| eachLogpath={logString} | ||
| logName="Trial stdout:" | ||
| /> |
There was a problem hiding this comment.
why the log of pai mode use 2 different components? can they use the same PaiTrialLog component?
There was a problem hiding this comment.
logPathChild just confirm that log string is hyperlink. But log nested components will refactor next release.
SparkSnail
reviewed
Aug 21, 2020
| if (isNaNorInfinity(val)) { | ||
| return `${val}`; // show 'NaN' or 'Infinity' | ||
| } else { | ||
| return `${formatAccuracy(val)} (FINAL)`; | ||
| if (this.accuracy === undefined) { |
There was a problem hiding this comment.
Is this.accuracy final result value?
colorjam
approved these changes
Aug 21, 2020
SparkSnail
approved these changes
Aug 24, 2020
ultmaster
approved these changes
Aug 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@colorjam
about table open row
logHDFStoNFStrial stdoutasTrial stdoutand show Trial stdout as hyperlink on pai mode@SparkSnail
FINAL | LATESTcorectlyabout compare modal:
some format changes.