This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
TF compression fix and UT #2817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chicm-ms
reviewed
Aug 24, 2020
chicm-ms
reviewed
Aug 24, 2020
|
|
||
| class TfCompressorTestCase(TestCase): | ||
|
|
||
| def test_layer_detection(self): |
There was a problem hiding this comment.
maybe to skip the tests if tf version is 1.x ? since we have pipelines with tf 1.x installed
QuanluZhang
reviewed
Aug 24, 2020
| @@ -75,6 +78,8 @@ class Compressor: | |||
|
|
|||
| def __init__(self, LayerWrapperClass, model, config_list): | |||
| assert isinstance(model, tf.keras.Model) | |||
| if isinstance(model, tf.keras.Sequential): | |||
| raise ValueError('NNI model compression does not support `Sequential` model for now') | |||
There was a problem hiding this comment.
why does not support Sequential?
There was a problem hiding this comment.
Because it's too hard to modify its attributes properly. Sequential abuses complex properties, they are multi-layered, sometimes cached, and sometimes dynamic.
chicm-ms
approved these changes
Aug 24, 2020
QuanluZhang
approved these changes
Aug 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tf.keras.Sequentialis too tricky to compress, removed from v1.8 release.