This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Fix eslint for json_utils.ts #2911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lijiaoa
approved these changes
Sep 21, 2020
liuzhe-lz
reviewed
Sep 21, 2020
| @@ -50,7 +49,7 @@ function batchFormat( | |||
|
|
|||
| const hasNested = nonNull.some(obj => detectNested(obj)); | |||
|
|
|||
| if (!hasNested && lines.every(line => (line.length + curIndent.length < width))) { | |||
| if (!hasNested && lines.every(line => line.length + curIndent.length < width)) { | |||
There was a problem hiding this comment.
I personally think this expression is really hard to read...
liuzhe-lz
approved these changes
Sep 21, 2020
chicm-ms
approved these changes
Sep 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
json_utils.tssomehow doesn't pass the pipeline now.I don't know how that happened. Maybe we are testing HEAD instead of MERGE?