This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Support show trial command on (remote | reuse) mode #3020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lijiaoa
changed the title
SparkSnail
reviewed
Oct 22, 2020
| @@ -10,7 +10,7 @@ export const Command2 = (): any => { | |||
|
|
|||
| if (clusterMetaData !== undefined) { | |||
| for (const item of clusterMetaData) { | |||
| if (item.key === 'command') { | |||
| if (item.key === 'command' || item.key === 'trial_config') { | |||
| trialCommand = item.value; | |||
There was a problem hiding this comment.
the data format in trial_config is {"command":"python3..", "gpuNum":"",...}, should use item.value.command for trial_config.
SparkSnail
reviewed
Oct 22, 2020
| trialCommand = item.value as string; | ||
| } | ||
| if (item.key === 'trial_config') { | ||
| trialCommand = item.value['command']; |
There was a problem hiding this comment.
if 'command' field does not exist in trial_config, will this line cause webui crash?
There was a problem hiding this comment.
Why not item.value.command?
There was a problem hiding this comment.
had fix this question
ultmaster
approved these changes
Oct 22, 2020
SparkSnail
reviewed
Oct 22, 2020
src/webui/src/static/interface.ts
Outdated
| command?: string; | ||
| codeDir?: string; | ||
| image?: string; | ||
| gpuNum?: number; |
There was a problem hiding this comment.
There might be more items trial_config, like 'virtualCluster', 'memoryMB', 'paiStorageConfigName', will this work if more items added in trial_config?
SparkSnail
approved these changes
Oct 22, 2020
961974
approved these changes
Oct 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remote, reuse, aml:
local:
