This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
[DO NOT Squash!] merge v1.9 back to master #3021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuanluZhang
requested review from
liuzhe-lz,
SparkSnail,
ultmaster and
chicm-ms
SparkSnail
reviewed
Oct 22, 2020
| @@ -18,7 +18,7 @@ For now, auto-completion will not be enabled by default if you install NNI throu | |||
| cd ~ | |||
| wget https://raw.githubusercontent.com/microsoft/nni/{nni-version}/tools/bash-completion | |||
| ``` | |||
| Here, {nni-version} should by replaced by the version of NNI, e.g., `master`, `v1.9`. You can also check the latest `bash-completion` script [here](https://github.com/microsoft/nni/blob/master/tools/bash-completion). | |||
| Here, {nni-version} should by replaced by the version of NNI, e.g., `master`, `v1.9`. You can also check the latest `bash-completion` script [here](https://github.com/microsoft/nni/blob/v1.9/tools/bash-completion). | |||
There was a problem hiding this comment.
use 1.9 doc in master branch?
There was a problem hiding this comment.
we can keep it for now, because master branch will be used for developing v2.0 which may have large changes
There was a problem hiding this comment.
well, how about set v1.9 as the default branch for users?
ultmaster
approved these changes
Oct 22, 2020
Lijiaoa
approved these changes
Oct 22, 2020
liuzhe-lz
approved these changes
Oct 23, 2020
chicm-ms
approved these changes
Oct 23, 2020
961974
approved these changes
Oct 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.