Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

Retiarii graph and code generation test #3231

Merged
merged 8 commits into from
Jan 5, 2021

Conversation

ultmaster
Copy link
Contributor

@ultmaster ultmaster commented Dec 24, 2020

Sorted in priority from high to low.

  • Support customized call method. (for example self.encode in self.forward)
  • Support operator prim::ListUnpack.
  • If condition: self.upsample
  • Support torchvision models.
  • Complex argument list in snli.

I've bypassed the corresponding tests for now.


Workarounded issues:

  • id is not reliable for records as it an be reused when objects have been destroyed.
  • records should be cleared when the whole procedure is completed.

Question: Are records actually needed in most cases?

UPD: records have been refactored in another PR.

@QuanluZhang QuanluZhang merged commit 0f88b86 into microsoft:v2.0 Jan 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants