This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Change command lines as serial. #3367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J-shang
approved these changes
Feb 19, 2021
|
What's the purpose of this change? |
SparkSnail
reviewed
Feb 22, 2021
| @@ -46,7 +46,7 @@ class WindowsCommands extends OsCommands { | |||
| } | |||
|
|
|||
| public generateGpuStatsScript(scriptFolder: string): string { | |||
| return `powershell -command $env:Path=If($env:prePath){$env:prePath}Else{$env:Path};$env:METRIC_OUTPUT_DIR='${scriptFolder}';$app = Start-Process -FilePath python -NoNewWindow -passthru -ArgumentList '-m nni.tools.gpu_tool.gpu_metrics_collector' -RedirectStandardOutput ${scriptFolder}\\scriptstdout -RedirectStandardError ${scriptFolder}\\scriptstderr;Write $PID ^| Out-File ${scriptFolder}\\pid -NoNewline -encoding utf8;wait-process $app.ID`; | |||
| return `powershell -command $setEnv = Start-Job -script {$env:Path=If($env:prePath){$env:prePath}Else{$env:Path};$env:METRIC_OUTPUT_DIR='${scriptFolder}'};wait-job $setEnv;$app = Start-Process -FilePath python -NoNewWindow -passthru -ArgumentList '-m nni.tools.gpu_tool.gpu_metrics_collector' -RedirectStandardOutput ${scriptFolder}\\scriptstdout -RedirectStandardError ${scriptFolder}\\scriptstderr;Write $PID ^| Out-File ${scriptFolder}\\pid -NoNewline -encoding utf8;wait-process $app.ID`; | |||
There was a problem hiding this comment.
Why need to put $env into Start-Job?
There was a problem hiding this comment.
@acured because did not finish changing environment variables before starting the gpu_metrics_collector?
To fix this issue |
J-shang
reviewed
Feb 22, 2021
| preCommand: command1 && command2 && command3 | ||
|
|
||
| **注意**：因为 ``preCommand`` 每次都会在其他命令之前执行，所以强烈建议不要设置 **preCommand** 来对系统进行更改，即 ``mkdir`` or ``touch``. | ||
| pythonPath: ${replace_to_python_environment_path_in_your_remote_machine} |
There was a problem hiding this comment.
don't modify the Chinese doc directly, this part will auto-update.
|
Please add eng doc. |
Done. |
Miss ExperimentConfig.rst |
Done. |
SparkSnail
approved these changes
Feb 22, 2021
94 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.