This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Add check for dependent packages of tuners before starting restful server #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add packages check before start restful server.
|
|
egg-west
changed the title
QuanluZhang
reviewed
Jan 6, 2019
xuehui1991
reviewed
Jan 8, 2019
xuehui1991
reviewed
Jan 8, 2019
chicm-ms
reviewed
Jan 8, 2019
xuehui1991
reviewed
Jan 9, 2019
xuehui1991
approved these changes
Jan 10, 2019
goooxu
approved these changes
Jan 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried SMAC tuner on mnist trial. And it seems everything works fine until I failed to open WebUI. After figuring out that SMAC has 2 packages to install, I think the launcher should deal with this and show the error rather than pretend to working fine.
So I add this check in
launcher.py. And to keep the maintain convenient, I copied the map from tuners' name to their module innnitoconstatnts.py.