Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

Doc fix: formats and typo. #582

Merged
merged 19 commits into from
Jan 11, 2019
Merged

Doc fix: formats and typo. #582

merged 19 commits into from
Jan 11, 2019

Conversation

squirrelsc
Copy link
Member

No description provided.

@QuanluZhang
Copy link
Contributor

suggest to change back to CRLF

@PurityFan
Copy link
Contributor

Great job!
But I am a little worried, because this pr and the branch of dev-doc modify the same document, such as "Overview". And this two modification seems to be difficult to merge due to lots of conflict, I am wondering if we will eventually have a big trouble when merging?

@squirrelsc squirrelsc changed the base branch from master to dev-doc January 10, 2019 10:00
@squirrelsc squirrelsc changed the base branch from dev-doc to master January 10, 2019 10:02
@@ -67,3 +67,5 @@ typings/
__pycache__
build
*.egg-info

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we can remove .vscode in gitignore.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.vscode is for vs code local settings. It's better to keep it local, instead of sharing.

python pip should also be correctly installed. You could use "python3 -m pip -v" to check in Linux.

* Note: we don't support virtual environment in current releases.
* Note: we don't support virtual environment in current releases.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that virtual environment like conda is supported if we install it in the right way.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no change on original content, I just changed indent of those lines. We can review content again, and get it correctly.

@squirrelsc squirrelsc merged commit efa479b into microsoft:master Jan 11, 2019
@squirrelsc squirrelsc deleted the doc_fix branch January 14, 2019 06:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants