Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

fix warning for homepage build #680

Merged
merged 8 commits into from
Jan 30, 2019

Conversation

leckie-chn
Copy link
Contributor

@leckie-chn leckie-chn commented Jan 29, 2019

also

Also suggest that using links to homepage instead in README.md

@QuanluZhang QuanluZhang requested review from squirrelsc, scarlett2018 and yds05 and removed request for squirrelsc and scarlett2018 January 29, 2019 10:26
nni.report_final_result(metrics)
```
`metrics` also could be any python object. If users use NNI built-in tuner/assessor, `metrics` follows the same format rule as that in `report_intermediate_result`, the number indicates the model's performance, for example, the model's accuracy, loss etc. This `metrics` is reported to [tuner](Builtin-Tuner.md).
`metrics` also could be any python object. If users use NNI built-in tuner/assessor, `metrics` follows the same format rule as that in `report_intermediate_result`, the number indicates the model's performance, for example, the model's accuracy, loss etc. This `metrics` is reported to [tuner](tuners.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tuners.md?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://nni.readthedocs.io/en/latest/KubeflowMode.html

Let's remove the email in the last para

Any problems when using NNI in kubeflow mode, plesae create issues on NNI github repo, or send mail to nni@microsoft.com

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://nni.readthedocs.io/en/latest/KubeflowMode.html

The "here" in below para reached nowhere.

We already build a docker image msranni/nni on Docker Hub. It contains NNI python packages, Node modules and javascript artifact files required to start experiment, and all of NNI dependencies. The docker file used to build this image can be found at here. You can either use this image directly in your config file, or build your own image based on it.

https://nni.readthedocs.io/en/deployment/Dockerfile.build.base

Got this:
SORRY /
\ /
\ This page does /
] not exist yet. [ ,'|
] [ / |
]___ [ ,' |
] ]\ /[ [ |: |
] ] \ / [ [ |: |
] ] ] [ [ [ |: |
] ] ]
__[ [ [ |: |
] ] ] ]\ _ /[ [ [ [ |: |
] ] ] ] (#) [ [ [ [ :===='
] ] ]
].nHn.[_[ [ [
] ] ] HHHHH. [ [ [
] ] / `HH("N \ [ [
]]/ HHH " [[
] NNN [
] N/" [
] N H [
/ N
/ q,
/ \

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://nni.readthedocs.io/en/latest/AdvancedNAS.html#weight-sharing-among-trials

"simple weight sharing example" goes no where.

For details, please refer to this simple weight sharing example. We also provided a practice example for reading comprehension, based on previous ga_squad example.

Copy link
Contributor Author

@leckie-chn leckie-chn Jan 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@QuanluZhang actually it's tuners.rst, but recommonmark only recognize .md as hyperlink, and will convert it to tuners.html anyway.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scarlett2018 for FAQ & email issue, please refer to e439d42
and 1f5f04e
Other deadlinks are already fixed in previous commits.

All those changes can take effect only after this PR is merged.

@leckie-chn leckie-chn merged commit 4539b4d into microsoft:master Jan 30, 2019
@leckie-chn leckie-chn deleted the doc-warning-fix branch January 30, 2019 03:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants