This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
fix bug in smac that configspace cannot deal with complex searchspace #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yds05
reviewed
Feb 8, 2019
| json.dumps(list(range(choice_len)))[1:-1], | ||
| json.dumps(0))) | ||
| if key in categorical_dict: | ||
| raise RuntimeError('%s has already existed, please make sure no search space with the same key.' % key) |
There was a problem hiding this comment.
change 'the same' to 'duplicate' may be more precise for this case? like:
'please make sure search space has no duplicate key'
There was a problem hiding this comment.
good suggestion, thanks
yds05
reviewed
Feb 8, 2019
| search_space = nni_search_space_content | ||
| with open('param_config_space.pcs', 'w') as pcs_fd: | ||
| if isinstance(search_space, dict): | ||
| for key in search_space.keys(): | ||
| if isinstance(search_space[key], dict): | ||
| try: | ||
| if search_space[key]['_type'] == 'choice': | ||
| choice_len = len(search_space[key]['_value']) |
There was a problem hiding this comment.
Is it possible that user's search space has no 'choice' value?
There was a problem hiding this comment.
yes, it is. If there is no choice, no need to do convert for categorical in smac
yds05
approved these changes
Feb 9, 2019
chicm-ms
approved these changes
Feb 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in nni 0.5 and higher, mnist-annotation example cannot be tuned by SMAC tuner, because SMAC cannot parse categorical values which include ",() ". In this pr, we fixed this problem.