This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Fix localTrainingService stream #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix remote bug (microsoft#523)
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
fix annotation key-error (microsoft#806)
Fix integration test dependencies (microsoft#822)
merge master
merge master
merge master
Fix installation (microsoft#864)
merge master
merge master
chicm-ms
reviewed
Mar 26, 2019
| throw new Error(`Could not find stream in trial ${trialJob.id}`); | ||
| } | ||
| stream.destroy(); | ||
| this.jobStreamMap.delete(trialJob.id); |
There was a problem hiding this comment.
This is not a good place to destroy job stream , it is better to put it into onTrialJobStatusChanged.
There was a problem hiding this comment.
moved to onTrialJobStatusChanged.
goooxu
approved these changes
Mar 26, 2019
added 2 commits
March 26, 2019 16:42
chicm-ms
reviewed
Mar 26, 2019
| throw new Error(`Could not find stream in trial ${trialJob.id}`); | ||
| } | ||
| stream.destroy(); | ||
| this.jobStreamMap.delete(trialJob.id); |
There was a problem hiding this comment.
I assume this is not specific for GPU, looks like should move to parent class.
There was a problem hiding this comment.
moved to parent class
chicm-ms
approved these changes
Mar 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issue #867