Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.2.1 has a breaking change #85

Closed
ljharb opened this issue Feb 14, 2024 · 5 comments
Closed

v3.2.1 has a breaking change #85

ljharb opened this issue Feb 14, 2024 · 5 comments

Comments

@ljharb
Copy link

ljharb commented Feb 14, 2024

Specifically, it uses the ?? operator, which doesn't work in node 12 (and breaks eslint-plugin-import tests).

It was added here: #81 (comment)

Please remove use of this operator and publish a v3.2.2?

(I'm happy to make a PR if that's needed)

ljharb added a commit to import-js/eslint-plugin-import that referenced this issue Feb 14, 2024
@ljharb
Copy link
Author

ljharb commented Feb 16, 2024

ping @aeschli

@aeschli
Copy link
Contributor

aeschli commented Feb 19, 2024

We want to move forward and not commit to be backward compatible. We currently compile against es2020 and for that you need Node 14.
Node 12 has reached end of line status almost 2 years ago.

Is there maybe a packager that you can useto back-compile?

@aeschli aeschli closed this as completed Feb 19, 2024
@ljharb
Copy link
Author

ljharb commented Feb 19, 2024

@aeschli that’s now how semver works, and no, it’s not safe to transpile code one didn’t author.

The proper way to move forward is a breaking change whenever you drop support for a node version. This position means this package is not semver-compliant.

@aeschli
Copy link
Contributor

aeschli commented Feb 20, 2024

We actually switched to es2020 already for 3.2.0. This is documented in the [CHANGELOG}( https://github.com/microsoft/node-jsonc-parser/blob/main/CHANGELOG.md)

Maybe what should have happend is to add an engine property. I will add that ASAP.

@ljharb
Copy link
Author

ljharb commented Feb 20, 2024

ok, that’s still a breaking change in v3.2.0. You have to bump the major when you drop any platform/engine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants