Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kill ESRCH exception can throw when killing terminals #159

Closed
Tyriar opened this issue Nov 10, 2017 · 1 comment
Closed

kill ESRCH exception can throw when killing terminals #159

Tyriar opened this issue Nov 10, 2017 · 1 comment
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug
Milestone
0.7.3

Comments

@Tyriar
Copy link
Member

Tyriar commented Nov 10, 2017

This node exception is thrown when attempting to kill processes whose pid doesn't exist.
@Tyriar Tyriar added the bug Issue identified by VS Code Team member as probable bug label Nov 10, 2017
@Tyriar Tyriar added this to the 0.7.3 milestone Nov 10, 2017
@Tyriar Tyriar self-assigned this Nov 10, 2017
Tyriar added a commit that referenced this issue Nov 10, 2017
@Tyriar
Swallow kill ESRCH exceptions when killing process tree
f8a75f1 
Fixes #159
@Tyriar Tyriar mentioned this issue Nov 10, 2017
Merged
@Tyriar
Copy link
Member Author

Tyriar commented Nov 10, 2017

I think the fix for this will also fix the flakiness on appveyor

@Tyriar Tyriar mentioned this issue Dec 14, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
0.7.3
Development

No branches or pull requests
1 participant
@Tyriar