Changed unix version of .kill function to send signals to all processes #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just one remark - imho AIX has none of the ioctls, might be better to change the #error into a warning and import |
… process.kill for .kill function otherwise
|
Ok, now it should output a warning, not export PtyKill, and fall back to process.kill if TIOCSIG and TIOCSIGNAL aren't available. |
|
LGTM 👍 |
Tyriar
requested changes
Dec 18, 2017
src/unixTerminal.ts
Outdated
| } | ||
| } catch (e) { /* swallow */ } | ||
| } else { | ||
| // Unknown signal |
There was a problem hiding this comment.
Let's throw a new Error here to make known that nothing happened.
src/unixTerminal.ts
Outdated
| signal = signal || 'SIGHUP'; | ||
| if (signal in os.constants.signals) { | ||
| try { | ||
| if (pty.kill && signal !== 'SIGHUP') { |
There was a problem hiding this comment.
A comment explaining why this is needed would be good here.
Tyriar
reviewed
Dec 18, 2017
src/unix/pty.cc
Outdated
| NAN_METHOD(PtyKill) { | ||
| Nan::HandleScope scope; | ||
|
|
||
| if (info.Length() != 2 || !info[0]->IsNumber()) { |
There was a problem hiding this comment.
Should have check the type of info[1]
…ignal is specified
|
Ok, I've made the changes. |
Tyriar
approved these changes
Dec 31, 2017
|
Thanks! 😃 |
This was referenced Mar 15, 2020
|
It's complicated. See: #206
TLDR: The ioctl had some limitations I wasn't aware of which had lead to
a regression.
I made a merge request to fix it, but the project had changed to the
microsoft organisation, and thus started requiring a CLA.
For ideological reasons, I do not sign any CLAs. Never ever. It is
understandable that this MR was reverted too as a result.
That said, I'm not sure if this is still the best way to handle such
things anymore anyway.
It seams for some signals, there are ways to assign escape sequences
that will generate a signal to a tty.
https://unix.stackexchange.com/questions/362559/list-of-terminal-generated-signals-eg-ctrl-c-sigint#answer-362579
So just sending the appropriate escape sequence to the ptm is probably a
better solution, although I haven't tested this.
And to make sure really all started programs get a signal, for example
to terminate them, there are probably better although more complicated
ways to do that involving cgroups.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes the unix version of the .kill function to send the signal to all processes of the process group of the pts using the TIOCSIG or TIOCSIGNAL ioctl, except for the SIGHUP signal, for which the original behaviour is retained.
See #167 for details