Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix C# phi-2 test #1050

Merged
merged 3 commits into from
Nov 18, 2024
Merged

Fix C# phi-2 test #1050

merged 3 commits into from
Nov 18, 2024

Conversation

skyline75489
Copy link
Contributor

@skyline75489 skyline75489 commented Nov 8, 2024 •
edited
Loading

The C# phi-2 test was skipped due to the wrong model path. This PR intends to fix it.

@skyline75489 skyline75489 marked this pull request as ready for review November 15, 2024 01:45
@skyline75489 skyline75489 requested a review from a team as a code owner November 15, 2024 01:45
@skyline75489
Copy link
Contributor Author

Note that there's still resource leaks in the C# tests. Will try to fix it later.

@skyline75489 skyline75489 merged commit 1bcd153 into main Nov 18, 2024
13 checks passed
@skyline75489 skyline75489 deleted the jialli/csharp-phi2 branch November 18, 2024 03:40
ajindal1 pushed a commit that referenced this pull request Nov 21, 2024
@skyline75489 @ajindal1
Fix C# phi-2 test (#1050)
6bb21e7 
The C# phi-2 test was skipped due to the wrong model path. This PR
intends to fix it.
@ajindal1 ajindal1 mentioned this pull request Nov 21, 2024
Merged
ajindal1 added a commit that referenced this pull request Nov 22, 2024
@ajindal1 @skyline75489 @baijumeswani
Update Version and cherry pick PRs (#1088)
83896a1 
Update Version and cherry pick PRs #1050 and #1066

---------

Co-authored-by: Chester Liu <4710575+skyline75489@users.noreply.github.com>
Co-authored-by: Baiju Meswani <bmeswani@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanUnderhill RyanUnderhill RyanUnderhill approved these changes

@baijumeswani baijumeswani baijumeswani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skyline75489 @baijumeswani @RyanUnderhill