Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use memset on cpu only #1070

Merged
merged 1 commit into from
Nov 19, 2024
Merged

use memset on cpu only #1070

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/models/kv_cache.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,10 +177,8 @@ KV_Cache::KV_Cache(State& state)
} else
#endif
{
if (model_.device_type_ != DeviceType::WEBGPU) {
// FIXME: GetTensorMutableRawData might (depending on device) return device memory.
// In that case one can not memset on it.
// For now remove this for WebGPU but it should be fixed for other devices as well.
if (model_.device_type_ == DeviceType::CPU) {
// FIXME: this is a device ternsor and we can only use memset for cpu. Revisit for other EPs.
memset(presents_.back()->GetTensorMutableRawData(), 0, kv_cache_size_bytes);
}
}
Expand Down
Loading