-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
quantize_static fail with HistogramCalibrater. #17619
Labels
Comments
github-actions
bot
added
platform:windows
issues related to the Windows platform
quantization
issues related to quantization
labels
Sep 20, 2023
5 tasks
guotuofeng
added a commit
to microsoft/Olive
that referenced
this issue
Sep 20, 2023
## Describe your changes - move the onnxruntime import for calibrate to vitis execution to fix the onnxruntime 1.6 compatibility issue with openvino - pin resnet ORT version to wait microsoft/onnxruntime#17619 to be fixed. - disable vitis test for ORT 1.16 since the calibrator API is changed. - pin ort extension to 0.8.0 since the check_model will fail with latest version. - copy quant_pre_process code to olive to work-around the Windows temp folder clean permission error. microsoft/onnxruntime#17627 ## Checklist before requesting a review - [ ] Add unit tests for this change. - [x] Make sure all tests can pass. - [ ] Update documents if necessary. - [x] Format your code by running `pre-commit run --all-files` - [ ] Is this a user-facing change? If yes, give a description of this change to be included in the release notes. ## (Optional) Issue link
This was referenced Sep 22, 2023
yufenglee
pushed a commit
that referenced
this issue
Sep 25, 2023
### Description One quantization case was not covered by the current list of unit tests. This PR adds a unit test to cover that case with the fix. It fixes the issue #17619. ### Motivation and Context
trajepl
added a commit
to microsoft/Olive
that referenced
this issue
Sep 26, 2023
## Describe your changes 1. Only_onnxruntime to false when opt_level > 1 2. set quantization calibration_method to minmax as the bug from ort 1.16.0 microsoft/onnxruntime#17619 ## Checklist before requesting a review - [ ] Add unit tests for this change. - [ ] Make sure all tests can pass. - [ ] Update documents if necessary. - [ ] Format your code by running `pre-commit run --all-files` - [ ] Is this a user-facing change? If yes, give a description of this change to be included in the release notes. ## (Optional) Issue link
snnn
pushed a commit
that referenced
this issue
Sep 29, 2023
### Description One quantization case was not covered by the current list of unit tests. This PR adds a unit test to cover that case with the fix. It fixes the issue #17619. ### Motivation and Context
kleiti
pushed a commit
to kleiti/onnxruntime
that referenced
this issue
Mar 22, 2024
…t#17649) ### Description One quantization case was not covered by the current list of unit tests. This PR adds a unit test to cover that case with the fix. It fixes the issue microsoft#17619. ### Motivation and Context
ubuntu: 18.04. cuda 11.4
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Describe the issue
In quantize_static, the TensorsData is created by using
However, in
TensorData.__init__
, the following logic is check the keyword args.We can see the histogram key is not in the allowed keyword, therefore the following errors are raised.
To reproduce
See https://aiinfra.visualstudio.com/PublicPackages/_build/results?buildId=357286&view=logs&jobId=35ea891e-7d20-5395-2445-be2fa0298764&j=5f33dc1f-8f24-5b97-62d3-f49845ddf6c9&t=d902c85d-ad1e-5c9a-ae64-6b490d39ff57.
Urgency
This bug break the onnxruntime quantization. it is a blocker.
Platform
Windows
OS Version
10
ONNX Runtime Installation
Released Package
ONNX Runtime Version or Commit ID
1.6.0
ONNX Runtime API
Python
Architecture
X64
Execution Provider
Default CPU
Execution Provider Library Version
No response
The text was updated successfully, but these errors were encountered: