Updates to CUDA and TensorRT dockerfiles for v0.5.0 #1731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manashgoswami
previously approved these changes
Aug 29, 2019
Our thinking here was that AML has necessary drivers for CUDA 10.1, Also, The TensorRT base image from Nvidia is using CUDA 10.1 |
Fine. I'll ask Faith what to do. @faxu |
|
quick bump on this PR. @jywu-msft, @faxu, @snnn, @manashgoswami -- any additional input? This is ready to be merged from my side. |
…o vinitra/docker-image-updates
jywu-msft
approved these changes
Sep 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This PR updates the CUDA dockerfile base image to use CUDA 10.1 and TensorRT dockerfile to use version 19.06.
Motivation and Context
This way we align with our CI and stay consistent with our newest MCR image updates.
Also adds clear documentation of tags provided to the README.
Relevant to updates made while addressing Tag ORT server images with version_number #1696