-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CUDA] upgrade cutlass to 3.5.0 #20940
Conversation
onnxruntime/core/mickey/cutlass_ext/q4gemm/threadblock/quantb_mma_multistage.h
Show resolved
Hide resolved
onnxruntime/core/mickey/cutlass_ext/q4gemm/threadblock/quantb_mma_multistage.h
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not disable C4996. See https://github.com/microsoft/onnxruntime/blob/main/docs/Coding_Conventions_and_Standards.md
If the warning was generated when compiling an external *.cc/*.cpp
file that is not part of our source tree, usually it wouldn't cause a build failure since we do not treat some warnings as errors
Otherwise, use tricks like https://github.com/microsoft/onnxruntime/blob/main/include/onnxruntime/core/common/eigen_common_wrapper.h
6adb2cd
to
415c5e1
Compare
Description
Upgrade cutlass to 3.5 to fix build errors using CUDA 12.4 or 12.5 in Windows
hrsqrt
not found error for sm < 53.The following are not included in this PR:
--cmake_extra_defines onnxruntime_ENABLE_CUDA_EP_INTERNAL_TESTS=ON
in build command.To integrate to rel-1.18.1: Either bring in other changes (like onnx 1.16.1), or generate manifest and upload a new ONNX Runtime Build Time Deps artifact based on rel-1.18.1.
Motivation and Context
#19891
#20924
#20953